Fixed #575. The select all is not triggering the onChange anymore. Only the...

Fixed #575. The select all is not triggering the onChange anymore. Only the onSelectAll is triggered.

dist/js/bootstrap-multiselect.js

@@ -509,8 +509,7 @@
                         this.deselectAll(this.options.selectAllJustVisible);
                     }
                 }
-
-                if(!isSelectAllOption){
+                else {
                     if (checked) {
                         $option.prop('selected', true);
 
@@ -539,6 +538,9 @@
                         // Unselect option.
                         $option.prop('selected', false);
                     }
+                    
+                    // To prevent select all from firing onChange: #575
+                    this.options.onChange($option, checked);
                 }
 
                 this.$select.change();
@@ -546,8 +548,6 @@
                 this.updateButtonText();
                 this.updateSelectAll();
 
-                this.options.onChange($option, checked);
-
                 if(this.options.preventInputChangeEvent) {
                     return false;
                 }

index.html

@@ -198,7 +198,7 @@
                                 <td><a href="#configuration-options-nonSelectedText"><code>nonSelectedText</code></a></td>
                             </tr>
                             <tr>
-                                <td><a href="#configuration-options-nSelectedText"><code>buttonText</code></a></td>
+                                <td><a href="#configuration-options-nSelectedText"><code>nSelectedText</code></a></td>
                                 <td><a href="#configuration-options-allSelectedText"><code>allSelectedText</code></a></td>
                                 <td><a href="#configuration-options-numberDisplayed"><code>numberDisplayed</code></a></td>
                             </tr>
@@ -1597,6 +1597,36 @@
         });
     });
 &lt;/script&gt;
+</pre>
+                                    </div>
+                                    
+                                    <p>
+                                        Note that the <code>allSelectedText</code> is not shown if only one option is available.
+                                    </p>
+                                    
+                                    <div class="example">
+                                        <script type="text/javascript">
+                                            $(document).ready(function() {
+                                                $('#example-allSelectedText-allSelectedText-single').multiselect({
+                                                    includeSelectAllOption: true,
+                                                    allSelectedText: 'No option left ...'
+                                                });
+                                            });
+                                        </script>
+                                        <select id="example-allSelectedText-allSelectedText-single" multiple="multiple">
+                                            <option value="1">Option 1</option>
+                                        </select>
+                                    </div>
+                                    <div class="highlight">
+<pre class="prettyprint linenums">
+&lt;script type=&quot;text/javascript&quot;&gt;
+    $(document).ready(function() {
+        $('#example-allSelectedText-allSelectedText-single').multiselect({
+            includeSelectAllOption: true,
+            allSelectedText: 'No option left ...'
+        });
+    });
+&lt;/script&gt;
 </pre>
                                     </div>
                                 </td>

tests/spec/bootstrap-multiselect.js

@@ -455,6 +455,8 @@ describe('Bootstrap Multiselect "Select All".', function() {
     var onSelectAllTriggered = false;
     var onDeselectAllTriggered = false;
     
+    var fired = 0;
+    
     beforeEach(function() {
         var $select = $('<select id="multiselect" multiple="multiple"></select>');
         
@@ -473,6 +475,9 @@ describe('Bootstrap Multiselect "Select All".', function() {
             },
             onDeselectAll: function() {
                 onDeselectAllTriggered = true;
+            },
+            onChange: function(option, checked) {
+                fired++;
             }
         });
     });
@@ -612,6 +617,13 @@ describe('Bootstrap Multiselect "Select All".', function() {
         expect(onSelectAllTriggered).toBe(true);
     });
     
+    it('Should not trigger onChange for select all option.', function() {
+        fired = 0;
+        expect(fired).toBe(0);
+        $('#multiselect-container input[value="multiselect-all"]').click();
+        expect(fired).toBe(0);
+    });
+    
     afterEach(function() {
         $('#multiselect').multiselect('destroy');
         $('#multiselect').remove();