Commit f4ffcdf7 authored by David Stutz's avatar David Stutz

Merge pull request #58 from programcsharp/master

Normalize prop access
parents c7b5fb42 33311d45
...@@ -129,8 +129,7 @@ ...@@ -129,8 +129,7 @@
// Will build an dropdown element for the given option. // Will build an dropdown element for the given option.
createOptionValue: function(element) { createOptionValue: function(element) {
if ($(element).is(':selected')) { if ($(element).is(':selected')) {
$(element).attr('selected', 'selected'); $(element).attr('selected', 'selected').prop('selected', true);
$(element).prop('selected', 'selected');
} }
// Support the label attribute on options. // Support the label attribute on options.
...@@ -148,7 +147,7 @@ ...@@ -148,7 +147,7 @@
$('ul', this.$container).append(li); $('ul', this.$container).append(li);
if ($(element).is(':disabled')) { if ($(element).is(':disabled')) {
checkbox.attr('disabled', 'disabled').prop('disabled', 'disabled').parents('li').addClass('disabled') checkbox.attr('disabled', 'disabled').prop('disabled', true).parents('li').addClass('disabled');
} }
checkbox.prop('checked', selected); checkbox.prop('checked', selected);
...@@ -206,20 +205,22 @@ ...@@ -206,20 +205,22 @@
var option = $('option', this.$select).filter(function() { return $(this).val() == $(event.target).val(); }); var option = $('option', this.$select).filter(function() { return $(this).val() == $(event.target).val(); });
var $optionsNotThis = $('option', this.$select).not($(option)); var $optionsNotThis = $('option', this.$select).not($(option));
var $checkboxesNotThis = $('input', this.$container).not($(event.target)); var $checkboxesNotThis = $('input', this.$container).not($(event.target));
if (isSelectAllOption) { if (isSelectAllOption) {
$checkboxesNotThis.filter(function () { return $(this).is(':checked') != checked; }).trigger('click'); $checkboxesNotThis.filter(function () { return $(this).is(':checked') != checked; }).trigger('click');
} }
if (checked) { if (checked) {
option.attr('selected', 'selected'); option.prop('selected', true);
option.prop('selected', 'selected');
if (!this.options.multiple) { if (!this.options.multiple)
{
if (this.options.selectedClass) { if (this.options.selectedClass) {
$($checkboxesNotThis).parents('li').removeClass(this.options.selectedClass); $($checkboxesNotThis).parents('li').removeClass(this.options.selectedClass);
} }
$($checkboxesNotThis).prop('checked', false); $($checkboxesNotThis).prop('checked', false);
$optionsNotThis.removeAttr('selected').removeProp('selected'); $optionsNotThis.removeAttr('selected').prop('selected', false);
// It's a single selection, so close. // It's a single selection, so close.
$(this.$container).find(".multiselect.dropdown-toggle").click(); $(this.$container).find(".multiselect.dropdown-toggle").click();
...@@ -228,9 +229,10 @@ ...@@ -228,9 +229,10 @@
if (this.options.selectedClass == "active") { if (this.options.selectedClass == "active") {
$optionsNotThis.parents("a").css("outline", ""); $optionsNotThis.parents("a").css("outline", "");
} }
} }
else { else {
option.removeAttr('selected'); option.removeAttr('selected').prop('selected', false);
} }
var options = this.getSelected(); var options = this.getSelected();
...@@ -339,8 +341,7 @@ ...@@ -339,8 +341,7 @@
checkbox.prop('checked', true); checkbox.prop('checked', true);
option.attr('selected', 'selected'); option.attr('selected', 'selected').prop('selected', true);
option.prop('selected', 'selected');
var options = this.getSelected(); var options = this.getSelected();
$('button', this.$container).html(this.options.buttonText(options, this.$select)); $('button', this.$container).html(this.options.buttonText(options, this.$select));
...@@ -357,8 +358,7 @@ ...@@ -357,8 +358,7 @@
checkbox.prop('checked', false); checkbox.prop('checked', false);
option.removeAttr('selected'); option.removeAttr('selected').prop('selected', false);
option.removeProp('selected');
var options = this.getSelected(); var options = this.getSelected();
$('button', this.$container).html(this.options.buttonText(options, this.$select)); $('button', this.$container).html(this.options.buttonText(options, this.$select));
...@@ -379,14 +379,14 @@ ...@@ -379,14 +379,14 @@
// For IE 9 support. // For IE 9 support.
getSelected: function() { getSelected: function() {
if (navigator.appName == 'Microsoft Internet Explorer') { //if (navigator.appName == 'Microsoft Internet Explorer') {
var regex = new RegExp("MSIE ([0-9]{1,}[\.0-9]{0,})"); // var regex = new RegExp("MSIE ([0-9]{1,}[\.0-9]{0,})");
if (regex.exec(navigator.userAgent) != null) { // if (regex.exec(navigator.userAgent) != null) {
return $('option:selected[value!="select-all-option"]', this.$select); // return $('option:selected[value!="select-all-option"]', this.$select);
} // }
} //}
return $('option[selected][value!="select-all-option"]', this.$select); return $('option:selected[value!="select-all-option"]', this.$select);
} }
}; };
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment